[IO-779] IOUtils.byteArray(size) should add the verification to assure that the size is legal(size > 0), the illegal(size <=0) should throw IllegalArgumentException.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Information Provided
• Affects Version/s: 2.11.0
• Component/s: Utilities

Environment

windows 10

Language

Java

• Assignee: Unassigned
• Reporter: Jiangwei Liu
• Created: 23/Aug/22 09:20
• Updated: 20/Mar/23 22:19
• Resolved: 20/Mar/23 22:19

Description

IOUtils.byteArray(size) should add the verification to assure that the size is legal(size > 0), the illegal(size <=0) should throw IllegalArgumentException.
for an example:
IOUtils.byteArray(-1);
should throw java.lang.NegativeArraySizeException。

 

fixed code：

/**

• Returns a new byte array of the given size.
  *
• TODO Consider guarding or warning against large allocations...
  *
• @param size array size.
• @return a new byte array of the given size.
  *
• @exception IllegalArgumentException If {@code size <= 0}
  *
• @since 2.9.0
  */
  public static byte[] byteArray(final int size) {
    if (size <= 0) { *     throw new IllegalArgumentException("byte size <= 0"); *     }

    return new byte[size];
  }

 

test code：IOUtilsTest.java

@Test
public void testByteArrayWithIllegalSize() {
  try

{     int size = -1;     byte[] bytes = IOUtils.byteArray(size);     size = 0;     bytes = IOUtils.byteArray(size); }

  catch (Exception e)

{     assertEquals(e.getClass().getName(), IllegalArgumentException.class.getName());   }

}