Uploaded image for project: 'Commons IO'
  1. Commons IO
  2. IO-740

RegexFileFilter matches on full path instead of filename

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.9.0
    • 2.10.0
    • Filters
    • None

    Description

      org.apache.commons.io.filefilter.RegexFileFilter#accept(java.nio.file.Path, java.nio.file.attribute.BasicFileAttributes) is a new method added in 2.9.0 and it's javadoc states: 

      /**
       * Checks to see if the file name matches one of the regular expressions.
       *
       * @param path the path
       * @param attributes the path attributes
       * @return true if the file name matches one of the regular expressions
       */
      

      However in it's implementation: 

      return toFileVisitResult(pattern.matcher(path.toString()).matches(), path);
      

      it matches on path.toString() which will be the full path instead of the filename.

       

      This is also inconsistent with the other method  org.apache.commons.io.filefilter.RegexFileFilter#accept(java.io.File, java.lang.String) which does match only on filename.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              tomjo Tom Jorissen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: