[IO-715] ReaderInputStream does not mention behavior regarding CharsetEncoder.reset()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.12.0
• Component/s: Streams/Writers
• Assignee: Unassigned
• Reporter: Marcono1234
• Created: 03/Feb/21 03:05
• Updated: 07/Feb/22 19:27
• Resolved: 07/Feb/22 19:27

Description

Neither the class documentation of org.apache.commons.io.input.ReaderInputStream nor the documentation of the constructors taking CharsetEncoder arguments describe whether CharsetEncoder.reset() is called.

Since calling reset() is part of the encoding operation (see CharsetEncoder documentation), it should at least be specified whether this method is called or not.

Additionally it might make sense to call reset() (though this might be a breaking change?) because encoding from a new (?) reader with an already used encoder which is not reset might lead to unexpected and incorrect results.