[IO-703] FileUtils.directoryContains shall throw NullPointerException for null inputs

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0
• Assignee: Unassigned
• Reporter: Hao Zhong
• Created: 16/Jan/21 02:20
• Updated: 17/Feb/21 16:45
• Resolved: 17/Feb/21 16:45

Description

The code of this method is as follows:

 public static boolean directoryContains(final File directory, final File child) throws IOException {        // Fail fast against NullPointerException
        if (directory == null) {
            throw new IllegalArgumentException("Directory must not be null");
        }        if (!directory.isDirectory()) {
            throw new IllegalArgumentException("Not a directory: " + directory);
        }
       ...
}

When directory is null, it throws IllegalArgumentException, but all the other methods of this class throw NullPointerException:

 

   public static void copyToDirectory(final File src, final File destDir) throws IOException {
        if (src == null) {
            throw new NullPointerException("Source must not be null");
        }
 ....
}

 

private static void checkFileRequirements(final File src, final File dest) throws FileNotFoundException {
        if (src == null) {
            throw new NullPointerException("Source must not be null");
        }
        if (dest == null) {
            throw new NullPointerException("Destination must not be null");
        }
        if (!src.exists()) {
            throw new FileNotFoundException("Source '" + src + "' does not exist");
        }
    }