[IO-691] IOUtils copyLarge gives incorrect result with buffered stream and zip file

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Not A Bug
• Affects Version/s: 2.8.0
• Component/s: Utilities

Environment

Mac OS Catalina v 10.15.7 

Java 11 

MacBook Pro (16-inch, 2019)

• Assignee: Unassigned
• Reporter: Aymon de Broglie
• Created: 28/Oct/20 10:55
• Updated: 29/Oct/20 08:07
• Resolved: 29/Oct/20 08:07

Description

I run the following code 

 

import org.apache.commons.io.IOUtils;

import java.io.*;

class Scratch {

    public static void main(String[] args) throws IOException {
        String oldFilePath = "your_path/test.zip";
        String newFilePath = "your_path/new_zip.zip";
        InputStream inputStream = new FileInputStream(oldFilePath);

        File file = new File(newFilePath);
        file.createNewFile();

        IOUtils.copyLarge(inputStream, new BufferedOutputStream(new FileOutputStream(file)));
    }
}

I then try to open the new_zip.zip and it is impossible to open, the file is not well copied

However if I remove the BufferedOutputStream as below, the copy works correctly

import org.apache.commons.io.IOUtils;

import java.io.*;

class Scratch {

    public static void main(String[] args) throws IOException {
        String oldFilePath = "your_path/test.zip";
        String newFilePath = "your_path/new_zip.zip";
        InputStream inputStream = new FileInputStream(oldFilePath);

        File file = new File(newFilePath);
        file.createNewFile();

        IOUtils.copyLarge(inputStream, new FileOutputStream(file));
    }
}