[IO-686] IOUtils.toByteArray(InputStream) Javadoc does not match code

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.9.0
• Component/s: Utilities
• Assignee: Unassigned
• Reporter: Alan Moffat
• Created: 10/Sep/20 14:54
• Updated: 19/Jan/21 18:20
• Resolved: 19/Jan/21 18:20

Description

According to the code in the v2.8.0 release, passing null to the method should throw an exception, however it is producing an empty byte array instead.

/**
 * Gets the contents of an <code>InputStream</code> as a <code>byte[]</code>.
 * <p>
 * This method buffers the input internally, so there is no need to use a
 * <code>BufferedInputStream</code>.
 * </p>
 *
 * @param input the <code>InputStream</code> to read from
 * @return the requested byte array
 * @throws NullPointerException if the input is null
 * @throws IOException          if an I/O error occurs
 */
public static byte[] toByteArray(final InputStream input) throws IOException {
    try (final ByteArrayOutputStream output = new ByteArrayOutputStream()) {
        copy(input, output);
        return output.toByteArray();
    }
} 

This can be recreated by the following:

@Test
public void shouldThrowNullPointerException() {
    assertThrows(NullPointerException.class, () -> IOUtils.toByteArray((InputStream) null))
} 

On v2.7 the test passes, on v2.8.0 it fails.

Issue Links

• is related to: IO-690 IOUtils.toByteArray(null) no longer throws a NullPointerException