[IO-546] ClosedOutputStream#flush should throw

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.6
• Component/s: Streams/Writers
• Assignee: Pascal Schumacher
• Reporter: Tomas Celaya
• Created: 09/Aug/17 00:53
• Updated: 20/Oct/17 06:49
• Resolved: 13/Oct/17 16:44

Description

While debugging an issue involving usage of CloseShieldOutputStream I discovered that ClosedOutputStream#flush is not overridden and will silently succeed. Not sure how much of a breaking change this might be but I think it makes more sense for ClosedOutputStream#flush to throw. This is only really meaningful in contexts where multiple streams are being chained together and some of the streams before CloseShieldOutputStream perform buffering, but it would make behavior more consistent for these more complex use-cases.

Issue Links

• links to: GitHub Pull Request #42