[IO-372] FileUtils.moveDirectory can produce misleading error message on failiure

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5
• Assignee: Unassigned
• Reporter: Max
• Created: 07/Mar/13 19:05
• Updated: 08/Nov/16 17:58
• Resolved: 16/Apr/13 20:40

Description

I am seeing the following error message when trying to move a directory:

"Cannot move directory: /path/to/directory to a subdirectory of itself: /path/to/directory_renamed"

This statement is iincorrect the destination path is not a sub directory of the source path.

Looking at the source l.2752 the destination directory is being compared to the source directory without using a File.separator

Here's a patch for the current trunk.

Index: src/main/java/org/apache/commons/io/FileUtils.java
===================================================================
--- src/main/java/org/apache/commons/io/FileUtils.java	(revision 1453996)
+++ src/main/java/org/apache/commons/io/FileUtils.java	(working copy)
@@ -2803,7 +2803,7 @@
         }
         final boolean rename = srcDir.renameTo(destDir);
         if (!rename) {
-            if (destDir.getCanonicalPath().startsWith(srcDir.getCanonicalPath())) {
+            if (destDir.getCanonicalPath().startsWith(srcDir.getCanonicalPath() + File.separator)) {
                 throw new IOException("Cannot move directory: "+srcDir+" to a subdirectory of itself: "+destDir);
             }
             copyDirectory( srcDir, destDir );