[IO-280] Dubious use of mkdirs() return code

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.1
• Assignee: Unassigned
• Reporter: Sebb
• Created: 15/Aug/11 21:40
• Updated: 27/Aug/13 15:17
• Resolved: 30/Aug/11 13:56

Description

FileUtils.openOutputStream() has the following code:

File parent = file.getParentFile();
if (parent != null && parent.exists() == false) {
    if (parent.mkdirs() == false) {
        throw new IOException("File '" + file + "' could not be created");
    }
}

Now mkdirs() returns true only if the method actually created the directories; it's theoretically possible for the directory to be created in the window between the exists() and mkdirs() invocations. [Indeed the class actually checks for this in the forceMkdir() method]

It would be safer to use:

File parent = file.getParentFile();
if (parent != null && !parent.mkdirs() && !parent.isDirectory()) {
    throw new IOException("Directory '" + parent + "' could not be created"); // note changed text
}

Similarly elsewhere in the class where mkdirs() is used.

Issue Links

• relates to: JCI-67 Dubious use of mkdirs() return code