Commons IO
  1. Commons IO
  2. IO-274

Tailer returning partial lines when reaching EOF before EOL

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.1
    • Component/s: None
    • Labels:
      None

      Activity

      Transition Time In Source Status Execution Times Last Executer Last Execution Date
      Open Open Resolved Resolved
      1d 13h 19m 1 Sebb 26/May/11 11:03
      Resolved Resolved Closed Closed
      137d 5h 45m 1 Gary Gregory 10/Oct/11 16:49
      Gary Gregory made changes -
      Status Resolved [ 5 ] Closed [ 6 ]
      Hide
      Gary Gregory added a comment -

      Closing, we released version 2.1.

      Show
      Gary Gregory added a comment - Closing, we released version 2.1.
      Gary Gregory made changes -
      Fix Version/s 2.1 [ 12316027 ]
      Sebb made changes -
      Status Open [ 1 ] Resolved [ 5 ]
      Resolution Fixed [ 1 ]
      Hide
      Sebb added a comment -

      I've added the test case (disabled for now), and started looking at a patch.

      Show
      Sebb added a comment - I've added the test case (disabled for now), and started looking at a patch.
      Hide
      Joerg Schaible added a comment -

      Well, Harmony should contain similar functionality. I simply cannot say, if you can do this, although the Harmony code is ours. My gut feeling says yes, but IANAL.

      Show
      Joerg Schaible added a comment - Well, Harmony should contain similar functionality. I simply cannot say, if you can do this, although the Harmony code is ours. My gut feeling says yes, but IANAL.
      Frank Grimes made changes -
      Attachment TailerTest.patch [ 12480422 ]
      Hide
      Sebb added a comment -

      I deleted the patch - could you add just the test case again please?

      Show
      Sebb added a comment - I deleted the patch - could you add just the test case again please?
      Sebb made changes -
      Attachment Tailer.patch [ 12480315 ]
      Hide
      Frank Grimes added a comment -

      Whoops, I obviously wasn't thinking... had I thought to check I would have found the following which is quite clear: http://www.apache.org/licenses/GPL-compatibility.html

      I wonder if I am now tainted and if it's best just to let someone else fix the submitted test case...

      Show
      Frank Grimes added a comment - Whoops, I obviously wasn't thinking... had I thought to check I would have found the following which is quite clear: http://www.apache.org/licenses/GPL-compatibility.html I wonder if I am now tainted and if it's best just to let someone else fix the submitted test case...
      Hide
      Joerg Schaible added a comment -

      Since the comment in the patch indicates that the code was copied from the JDK, we cannot apply this patch - at least not the new method, only the unit test. Frank, you do not own the rights at this source code and therefore we cannot add it to our code base and relicense it. It's simply illegal.

      Show
      Joerg Schaible added a comment - Since the comment in the patch indicates that the code was copied from the JDK, we cannot apply this patch - at least not the new method, only the unit test. Frank, you do not own the rights at this source code and therefore we cannot add it to our code base and relicense it. It's simply illegal.
      Frank Grimes made changes -
      Field Original Value New Value
      Attachment Tailer.patch [ 12480315 ]
      Hide
      Frank Grimes added a comment -

      Test case and patch.

      Show
      Frank Grimes added a comment - Test case and patch.
      Frank Grimes created issue -

        People

        • Assignee:
          Unassigned
          Reporter:
          Frank Grimes
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development