Uploaded image for project: 'Commons IO'
  1. Commons IO
  2. IO-274

Tailer returning partial lines when reaching EOF before EOL

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.1
    • Component/s: None
    • Labels:
      None

      Activity

      Hide
      frankgrimes97 Frank Grimes added a comment -

      Test case and patch.

      Show
      frankgrimes97 Frank Grimes added a comment - Test case and patch.
      Hide
      joehni Joerg Schaible added a comment -

      Since the comment in the patch indicates that the code was copied from the JDK, we cannot apply this patch - at least not the new method, only the unit test. Frank, you do not own the rights at this source code and therefore we cannot add it to our code base and relicense it. It's simply illegal.

      Show
      joehni Joerg Schaible added a comment - Since the comment in the patch indicates that the code was copied from the JDK, we cannot apply this patch - at least not the new method, only the unit test. Frank, you do not own the rights at this source code and therefore we cannot add it to our code base and relicense it. It's simply illegal.
      Hide
      frankgrimes97 Frank Grimes added a comment -

      Whoops, I obviously wasn't thinking... had I thought to check I would have found the following which is quite clear: http://www.apache.org/licenses/GPL-compatibility.html

      I wonder if I am now tainted and if it's best just to let someone else fix the submitted test case...

      Show
      frankgrimes97 Frank Grimes added a comment - Whoops, I obviously wasn't thinking... had I thought to check I would have found the following which is quite clear: http://www.apache.org/licenses/GPL-compatibility.html I wonder if I am now tainted and if it's best just to let someone else fix the submitted test case...
      Hide
      sebb@apache.org Sebb added a comment -

      I deleted the patch - could you add just the test case again please?

      Show
      sebb@apache.org Sebb added a comment - I deleted the patch - could you add just the test case again please?
      Hide
      joehni Joerg Schaible added a comment -

      Well, Harmony should contain similar functionality. I simply cannot say, if you can do this, although the Harmony code is ours. My gut feeling says yes, but IANAL.

      Show
      joehni Joerg Schaible added a comment - Well, Harmony should contain similar functionality. I simply cannot say, if you can do this, although the Harmony code is ours. My gut feeling says yes, but IANAL.
      Hide
      sebb@apache.org Sebb added a comment -

      I've added the test case (disabled for now), and started looking at a patch.

      Show
      sebb@apache.org Sebb added a comment - I've added the test case (disabled for now), and started looking at a patch.
      Hide
      garydgregory Gary Gregory added a comment -

      Closing, we released version 2.1.

      Show
      garydgregory Gary Gregory added a comment - Closing, we released version 2.1.

        People

        • Assignee:
          Unassigned
          Reporter:
          frankgrimes97 Frank Grimes
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development