Uploaded image for project: 'Commons IO'
  1. Commons IO
  2. IO-257

BOMInputStream.read(byte[]) can return 0 which it should not

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.1
    • Component/s: Streams/Writers
    • Labels:
      None

      Description

      BOMInputStream.read(byte[]) returns 0 when it should return -1.

      This is not a valid action (unless buf.length == 0) and can cause problems, e.g. "java.io.IOException: Underlying input stream returned zero bytes - at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:268)"

      From java.io.InputStream.read(byte[]) JavaDocs: "If the length of b is zero, then no bytes are read and 0 is returned; otherwise, there is an attempt to read at least one byte. If no byte is available because the stream is at the end of the file, the value -1 is returned; otherwise, at least one byte is read and stored into b."

      Suggested fix, change line 287 of BOMInputStream.java from
      return (secondCount < 0) ? firstCount : firstCount + secondCount;
      into
      return (secondCount < 0) ? (firstCount > 0 ? firstCount : -1) : firstCount + secondCount;

        Attachments

          Activity

            People

            • Assignee:
              niallp Niall Pemberton
              Reporter:
              teme Teemu Lång
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: