Commons IO
  1. Commons IO
  2. IO-243

SwappedDataInputStream readBoolean is inverted

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0, 1.1, 1.2, 1.3, 1.3.1, 1.3.2, 1.4
    • Fix Version/s: 2.0
    • Component/s: Streams/Writers
    • Labels:
      None

      Description

      The method readBoolean in SwappedDataInputStream returns true when the byte is zero, false otherwise. In accordance with the contract in java.io.DataInput, true should indicate a non-zero byte. SwappedDataInputStream is for reading Little Endian formats, it should not change the boolean value of individual bytes.

        Activity

        Ray Myers created issue -
        Ray Myers made changes -
        Field Original Value New Value
        Attachment IO-243-SwappedDataInputStream-readBoolean.path [ 12440663 ]
        Ray Myers made changes -
        Attachment IO-243-SwappedDataInputStream-readBoolean.path [ 12440663 ]
        Ray Myers made changes -
        Hide
        Niall Pemberton added a comment -
        Show
        Niall Pemberton added a comment - Fixed, thanks for the patch! http://svn.apache.org/viewvc?view=revision&revision=995160
        Niall Pemberton made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Niall Pemberton [ niallp ]
        Fix Version/s 2.0 [ 12312961 ]
        Resolution Fixed [ 1 ]
        Mark Thomas made changes -
        Workflow jira [ 12503781 ] Default workflow, editable Closed status [ 12601915 ]
        Henri Yandell made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        158d 16h 40m 1 Niall Pemberton 08/Sep/10 18:16
        Resolved Resolved Closed Closed
        428d 52m 1 Henri Yandell 10/Nov/11 18:09

          People

          • Assignee:
            Niall Pemberton
            Reporter:
            Ray Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 10m
              10m
              Remaining:
              Remaining Estimate - 10m
              10m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development