[IO-240] FileFilterUtils can create cvsFilter and svnFilter more than once

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0
• Assignee: Niall Pemberton
• Reporter: Sebb
• Created: 05/Mar/10 00:15
• Updated: 10/Nov/11 18:09
• Resolved: 05/Aug/10 00:20

Description

FileFilterUtils lazily creates the static fields cvsFilter and svnFilter; however access to the fields is not synchronized and the fields are not volatile.

One thread can create the filter, but the updated value won't necessarily be seen by any/all other threads.

This means that the fields can be created multiple times.

Possible solutions: make the fields volatile, or use the singleton IODH idiom. The latter uses a bit more code, but is probably marginally cheaper if the field is used a lot.