[IO-235] Bugs in CopyUtilsTest test cases?

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0
• Assignee: Niall Pemberton
• Reporter: Sebb
• Created: 04/Mar/10 17:51
• Updated: 10/Nov/11 18:09
• Resolved: 04/Aug/10 23:02

Description

testCopy_byteArrayToWriter() has the following code:

ByteArrayOutputStream baout = new ByteArrayOutputStream();
OutputStream out = new YellOnFlushAndCloseOutputStream(baout, false, true); // out is not used
Writer writer = new java.io.OutputStreamWriter(baout, "US-ASCII"); // uses baout - should it use out instead

It looks like the Writer should be created from out rather than baout - otherwise why create out?

Similarly for

testCopy_inputStreamToWriter()
testCopy_readerToWriter()
testCopy_stringToWriter()

The tests still pass if the Writer is changed to use out.

Thoughts?