Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Component/s: None
    • Labels:
      None

      Description

      testCopy_byteArrayToWriter() has the following code:

      ByteArrayOutputStream baout = new ByteArrayOutputStream();
      OutputStream out = new YellOnFlushAndCloseOutputStream(baout, false, true); // out is not used
      Writer writer = new java.io.OutputStreamWriter(baout, "US-ASCII"); // uses baout - should it use out instead
      

      It looks like the Writer should be created from out rather than baout - otherwise why create out?

      Similarly for

      testCopy_inputStreamToWriter()
      testCopy_readerToWriter()
      testCopy_stringToWriter()

      The tests still pass if the Writer is changed to use out.

      Thoughts?

        Activity

        Henri Yandell made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Mark Thomas made changes -
        Workflow jira [ 12500858 ] Default workflow, editable Closed status [ 12601909 ]
        Niall Pemberton made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Niall Pemberton [ niallp ]
        Fix Version/s 2.0 [ 12312961 ]
        Resolution Fixed [ 1 ]
        Show
        Niall Pemberton added a comment - Fixed: http://svn.apache.org/viewvc?view=revision&revision=982430
        Niall Pemberton made changes -
        Field Original Value New Value
        Summary Bugs in test cases? Bugs in CopyUtilsTest test cases?
        Sebb created issue -

          People

          • Assignee:
            Niall Pemberton
            Reporter:
            Sebb
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development