Commons IO
  1. Commons IO
  2. IO-206

ProxyInputStream: misleading parameter names

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Streams/Writers
    • Labels:
      None

      Description

      ProxyInputStream has a the following method signatures:

      • public int read(byte[] bts, int st, int end)
      • public void mark(int idx)

      But they should be:

      • public int read(byte[] bts, int off, int length)
      • public void mark(int readlimit)

      Especially the "end" parameter could be misinterpreted.

        Activity

        Jeremias Maerki created issue -
        Jeremias Maerki made changes -
        Field Original Value New Value
        Attachment IO-206-ProxyInputStream-Param-Fix.diff [ 12408393 ]
        Niall Pemberton made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Niall Pemberton [ niallp ]
        Resolution Fixed [ 1 ]
        Henri Yandell made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Mark Thomas made changes -
        Workflow jira [ 12463731 ] Default workflow, editable Closed status [ 12601822 ]

          People

          • Assignee:
            Niall Pemberton
            Reporter:
            Jeremias Maerki
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development