Uploaded image for project: 'Commons IO'
  1. Commons IO
  2. IO-206

ProxyInputStream: misleading parameter names

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Streams/Writers
    • Labels:
      None

      Description

      ProxyInputStream has a the following method signatures:

      • public int read(byte[] bts, int st, int end)
      • public void mark(int idx)

      But they should be:

      • public int read(byte[] bts, int off, int length)
      • public void mark(int readlimit)

      Especially the "end" parameter could be misinterpreted.

        Attachments

          Activity

            People

            • Assignee:
              niallp Niall Pemberton
              Reporter:
              jeremias@apache.org Jeremias Maerki
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: