Commons IO
  1. Commons IO
  2. IO-206

ProxyInputStream: misleading parameter names

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Streams/Writers
    • Labels:
      None

      Description

      ProxyInputStream has a the following method signatures:

      • public int read(byte[] bts, int st, int end)
      • public void mark(int idx)

      But they should be:

      • public int read(byte[] bts, int off, int length)
      • public void mark(int readlimit)

      Especially the "end" parameter could be misinterpreted.

        Activity

        Hide
        Jeremias Maerki added a comment -

        For some reason, I can't currently commit to IO trunk. Attaching the patch.

        Show
        Jeremias Maerki added a comment - For some reason, I can't currently commit to IO trunk. Attaching the patch.
        Hide
        Niall Pemberton added a comment -
        Show
        Niall Pemberton added a comment - Fixed, thanks for the patch http://svn.apache.org/viewvc?view=rev&revision=776062

          People

          • Assignee:
            Niall Pemberton
            Reporter:
            Jeremias Maerki
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development