[IO-16] DirectoryFileFilter does not work, the AbstractFileFilter bug

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0
• Fix Version/s: 1.1

Environment

Operating System: Windows XP
Platform: PC

• Bugzilla Id: 30992
• Assignee: Unassigned
• Reporter: Nebojsa Perunicic
• Created: 01/Sep/04 21:44
• Updated: 09/Mar/07 20:38
• Resolved: 09/Mar/07 20:38

Description

Env: Java 1.4.2, commons-io-1.0.jar, Win XP

The AbstractFileFilter's FilenameFilter's accept(File, String) method
implementation constructs the fileName/File (it passes to accept(File))
wrongly - please see below. This causes the DirectoryFileFilter (in example, I
did not have time to check out the other AbstractFileFilter implementations)
failure since it's FileFilter implementation receives the incorrect
filename/File.

Note I stumbled into this in Win Env. and really don't know how it works in
other platforms.

v1.0 code:
public boolean accept(File dir, String name)

{ String filename = dir.getName() + File.separator + name; return accept(new File(filename)); }

correct code should be:
public boolean accept(File dir, String name)

{ String filename = dir.getPath() + File.separator + name; return accept(new File(filename)); }