Commons IO
  1. Commons IO
  2. IO-116

Replace static FileCleaner methods

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.3.1
    • Fix Version/s: 1.3.2
    • Component/s: Utilities
    • Labels:
      None

      Description

      The attached patch aims to finally resolve the problems, which are named in IO-99, FILEUPLOAD-120, and FILEUPLOAD-125.

      I choosed a conservative strategy: Basically I copied the FileCleaner class to an instantiable class FileCleaningTracker with instance methods. The static FileCleaner methods are now implemented by a static instance of FileCleaningTracker. (The name FileCleaningTracker is, of course, questionable.

      The FileCleaningTestCase was also created by simply copying FileCleaner to FileCleaningTestCase. FileCleanerTestCase is now similarly implemented as a subclass of FileCleanerTestCase which uses the static instance of FileCleaner rather than a dynamically created instance.

      1. commons-io-filecleaningtracker.patch
        43 kB
        Jochen Wiedmann
      2. commons-io-filecleaningtracker.patch
        43 kB
        Jochen Wiedmann

        Issue Links

          Activity

          Mark Thomas made changes -
          Workflow jira [ 12398575 ] Default workflow, editable Closed status [ 12601918 ]
          Henri Yandell made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Niall Pemberton made changes -
          Fix Version/s 1.3.2 [ 12312510 ]
          Fix Version/s 1.4 [ 12312101 ]
          Jochen Wiedmann made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Jochen Wiedmann made changes -
          Attachment commons-io-filecleaningtracker.patch [ 12353232 ]
          Jochen Wiedmann made changes -
          Link This issue relates to FILEUPLOAD-125 [ FILEUPLOAD-125 ]
          Jochen Wiedmann made changes -
          Link This issue is blocked by FILEUPLOAD-125 [ FILEUPLOAD-125 ]
          Jochen Wiedmann made changes -
          Link This issue is blocked by FILEUPLOAD-125 [ FILEUPLOAD-125 ]
          Jochen Wiedmann made changes -
          Field Original Value New Value
          Attachment commons-io-filecleaningtracker.patch [ 12352400 ]
          Jochen Wiedmann created issue -

            People

            • Assignee:
              Unassigned
              Reporter:
              Jochen Wiedmann
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development