Details

      Description

      We would like to get review board setup for Kafka.
      repo: http://git-wip-us.apache.org/repos/asf/kafka.git
      mailing list: dev@kafka.apache.org

      Thanks!

        Activity

        Jay Kreps created issue -
        Hide
        Jake Farrell added a comment -
        done
        Show
        Jake Farrell added a comment - done
        Jake Farrell made changes -
        Field Original Value New Value
        Status Waiting for Infra [ 10011 ] Closed [ 6 ]
        Assignee Jake Farrell [ jfarrell ]
        Resolution Fixed [ 1 ]
        Hide
        Jay Kreps added a comment -
        Thanks for setting this up. Unfortunately it doesn't quite work for me.

        If I try to upload a patch I get
        "Something broke! (Error 500)"
        I am using this patch: https://issues.apache.org/jira/secure/attachment/12599841/KAFKA-925-post-commit-v1.patch
        I am setting the repository to "kafka" and the base directory to "/".

        Trying another way if I install post-review and try to use that:

        jkreps$ git config reviewboard.url https://reviews.apache.org
        jkreps$ post-review --tracking-branch=origin/trunk
        ==> HTTP Authentication Required
        Enter authorization information for "Web API" at reviews.apache.org
        Username: jkreps
        Password:

        There was an error creating this review request.

        The repository path "https://git-wip-us.apache.org/repos/asf/kafka.git" is not in the
        list of known repositories on the server.

        Ask the administrator to add this repository to the Review Board server.
        For information on adding repositories, please read
        http://www.reviewboard.org/docs/manual/dev/admin/configuration/repositories/
        Show
        Jay Kreps added a comment - Thanks for setting this up. Unfortunately it doesn't quite work for me. If I try to upload a patch I get "Something broke! (Error 500)" I am using this patch: https://issues.apache.org/jira/secure/attachment/12599841/KAFKA-925-post-commit-v1.patch I am setting the repository to "kafka" and the base directory to "/". Trying another way if I install post-review and try to use that: jkreps$ git config reviewboard.url https://reviews.apache.org jkreps$ post-review --tracking-branch=origin/trunk ==> HTTP Authentication Required Enter authorization information for "Web API" at reviews.apache.org Username: jkreps Password: There was an error creating this review request. The repository path " https://git-wip-us.apache.org/repos/asf/kafka.git " is not in the list of known repositories on the server. Ask the administrator to add this repository to the Review Board server. For information on adding repositories, please read http://www.reviewboard.org/docs/manual/dev/admin/configuration/repositories/
        Jay Kreps made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Hide
        Jake Farrell added a comment -
        reviewboard uses git.apache.org as its repository source, not git-wip

        you will want to use: git://git.apache.org/kafka.git
        Show
        Jake Farrell added a comment - reviewboard uses git.apache.org as its repository source, not git-wip you will want to use: git://git.apache.org/kafka.git
        Jake Farrell made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        Jay Kreps added a comment -
        The second issues was just my mistake using the other git url. However the first issue remains. I tried a few things. Here is the problem: there are two "kafka" groups in the group selector, the first one will always result in the 500 error the second one works fine. Both look exactly the same in the UI. Can we remove whatever this bogus group is? It is confusing people trying to file reviews.
        Show
        Jay Kreps added a comment - The second issues was just my mistake using the other git url. However the first issue remains. I tried a few things. Here is the problem: there are two "kafka" groups in the group selector, the first one will always result in the 500 error the second one works fine. Both look exactly the same in the UI. Can we remove whatever this bogus group is? It is confusing people trying to file reviews.
        Jay Kreps made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Hide
        Jake Farrell added a comment -
        duplicate group was the incubator group, deleted
        Show
        Jake Farrell added a comment - duplicate group was the incubator group, deleted
        Jake Farrell made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Gavin made changes -
        Fix Version/s Initial Clearing [ 12325964 ]

          People

          • Assignee:
            Jake Farrell
            Reporter:
            Jay Kreps
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development