Details

      Description

      Hi,

      could you please set up ReviewBoard for Crunch?

      Thanks,
        Matthias

        Activity

        Matthias Friedrich created issue -
        Hide
        #asfinfra IRC Bot added a comment -
        <pctony> Matthias we need the URl for the repo, and which ML to send your comments too. Once we have this I can get it workingf
        Show
        #asfinfra IRC Bot added a comment - <pctony> Matthias we need the URl for the repo, and which ML to send your comments too. Once we have this I can get it workingf
        #asfinfra IRC Bot made changes -
        Field Original Value New Value
        Status Waiting for Infra [ 10011 ] Waiting for user [ 10010 ]
        Hide
        Matthias Friedrich added a comment -
        Show
        Matthias Friedrich added a comment - Please use repository https://git-wip-us.apache.org/repos/asf/incubator-crunch.git and crunch-dev@incubator.apache.org for comments. Thanks!
        Matthias Friedrich made changes -
        Status Waiting for user [ 10010 ] Waiting for Infra [ 10011 ]
        Gavin made changes -
        Assignee Gavin [ ipv6guru ]
        Hide
        Gavin added a comment -
        Done.
        Show
        Gavin added a comment - Done.
        Gavin made changes -
        Status Waiting for Infra [ 10011 ] Closed [ 6 ]
        Assignee Gavin [ ipv6guru ]
        Resolution Fixed [ 1 ]
        Hide
        Matthias Friedrich added a comment -
        Hmm, something doesn't seem to work. When I upload a diff in ReviewBoard (see CRUNCH-101 for an example) and click submit, I get the message "The file 'crunch/src/it/java/org/apache/crunch/EnumPairIT.java' (raa4f0c4) could not be found in the repository". This is the first file referenced from the diff, and it's definitely in the repository.

        Could you please have a look at what's wrong here? Thanks!

        Show
        Matthias Friedrich added a comment - Hmm, something doesn't seem to work. When I upload a diff in ReviewBoard (see CRUNCH-101 for an example) and click submit, I get the message "The file 'crunch/src/it/java/org/apache/crunch/EnumPairIT.java' (raa4f0c4) could not be found in the repository". This is the first file referenced from the diff, and it's definitely in the repository. Could you please have a look at what's wrong here? Thanks!
        Matthias Friedrich made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Hide
        Tony Stevenson added a comment -
        Matthias,

        This is what I see on the filesystem for the git repo in question -

        root@reviews-vm [/home/reviewboard/incubator-crunch/crunch/src/it/java/org/apache/crunch ] ls

        CollectionPObjectIT.java impl MapPObjectIT.java MaterializeToMapIT.java PageRankIT.java PTableKeyValueIT.java TextPairIT.java WordCountIT.java
        CollectionsIT.java io MapsIT.java MRPipelineIT.java PCollectionGetSizeIT.java TermFrequencyIT.java TfIdfIT.java
        FirstElementPObjectIT.java lib MaterializeIT.java MultipleOutputIT.java PObjectsIT.java test TupleNClassCastBugIT.java


        I do not see the EnumPairIT.java you say should be there.
        Show
        Tony Stevenson added a comment - Matthias, This is what I see on the filesystem for the git repo in question - root@reviews-vm [/home/reviewboard/incubator-crunch/crunch/src/it/java/org/apache/crunch ] ls CollectionPObjectIT.java impl MapPObjectIT.java MaterializeToMapIT.java PageRankIT.java PTableKeyValueIT.java TextPairIT.java WordCountIT.java CollectionsIT.java io MapsIT.java MRPipelineIT.java PCollectionGetSizeIT.java TermFrequencyIT.java TfIdfIT.java FirstElementPObjectIT.java lib MaterializeIT.java MultipleOutputIT.java PObjectsIT.java test TupleNClassCastBugIT.java I do not see the EnumPairIT.java you say should be there.
        Hide
        Tony Stevenson added a comment -
        This is the latest git log entry for the repo:

        commit c38a32bdf600b56088345326f0ecc30b51d73778
        Author: Josh Wills <jwills@apache.org>
        Date: Thu Sep 13 09:33:50 2012 -0700

            CRUNCH-54: Fix bug where we throw NPE when materializing a PCollection that has been written before
        Show
        Tony Stevenson added a comment - This is the latest git log entry for the repo: commit c38a32bdf600b56088345326f0ecc30b51d73778 Author: Josh Wills < jwills@apache.org > Date: Thu Sep 13 09:33:50 2012 -0700      CRUNCH-54 : Fix bug where we throw NPE when materializing a PCollection that has been written before
        Tony Stevenson made changes -
        Status Reopened [ 4 ] Waiting for user [ 10010 ]
        Hide
        Matthias Friedrich added a comment -
        Tony, thanks for having a look! There have been lots of changes to our git repository since September 13th. The file in question has been added 5 days later in commit 568e91cb6002a5e8d782e8ca9401f1515cb20ee6.
        Show
        Matthias Friedrich added a comment - Tony, thanks for having a look! There have been lots of changes to our git repository since September 13th. The file in question has been added 5 days later in commit 568e91cb6002a5e8d782e8ca9401f1515cb20ee6.
        Matthias Friedrich made changes -
        Status Waiting for user [ 10010 ] Waiting for Infra [ 10011 ]
        Gavin made changes -
        Assignee Gavin [ ipv6guru ]
        Hide
        Gavin added a comment -
        Done.

        I've re-organised how the git mirrors are fetched from git.a.o/$project.git and how they are subsequently updated.

        In your case, the git.a.o mirror (that mirrors your git-wip.a.o master) also needed locks removed before it would update.

        All good now.
        Show
        Gavin added a comment - Done. I've re-organised how the git mirrors are fetched from git.a.o/$project.git and how they are subsequently updated. In your case, the git.a.o mirror (that mirrors your git-wip.a.o master) also needed locks removed before it would update. All good now.
        Gavin made changes -
        Status Waiting for Infra [ 10011 ] Closed [ 6 ]
        Assignee Gavin [ ipv6guru ]
        Resolution Fixed [ 1 ]
        Gavin made changes -
        Fix Version/s Initial Clearing [ 12325964 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Matthias Friedrich
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development