Details

      Description

      The badheaders configuration file [1] says that:
      - "rating" can be "A", to accept all mail
      - "where" can be H or h for case-sensitive and case-insensitive header matching

      However, the script that processes it [2] does not handle the "A" rating, nor does it handle "where" with the value "H".

      Further, the script actually uses case-sensitive matching even though it only processes 'h' lines.

      [1] https://svn.apache.org/repos/infra/infrastructure/trunk/qmail/control/badheaders
      [2] https://svn.apache.org/repos/infra/infrastructure/qpsmtpd/plugins/check_badheaders
      1. INFRA-4365_2.patch
        1 kB
        Sebb
      2. INFRA-4365_1.patch
        0.8 kB
        Sebb

        Activity

        Hide
        #asfinfra Bot added a comment -
        <pctony> Sebb this later patch (i.e. _2.patch) has just been applied to the file, in r883901.
        Show
        #asfinfra Bot added a comment - <pctony> Sebb this later patch (i.e. _2.patch) has just been applied to the file, in r883901.
        Hide
        Tony Stevenson added a comment -
        Transitioning to waiting for Infra
        Show
        Tony Stevenson added a comment - Transitioning to waiting for Infra
        Hide
        Tony Stevenson added a comment -
        Joe, go for it.
        Show
        Tony Stevenson added a comment - Joe, go for it.
        Hide
        Joe Schaefer added a comment -
        Any reason why this patch shouldn't be applied?
        Show
        Joe Schaefer added a comment - Any reason why this patch shouldn't be applied?
        Show
        Sebb added a comment - https://mail-search.apache.org/members/private-arch/infrastructure/201201.mbox/%3C20120125010919.38ADB23889E7@eris.apache.org%3E in particular https://mail-search.apache.org/members/private-arch/infrastructure/201201.mbox/%3C1327463247.5779.YahooMailNeo@web160906.mail.bf1.yahoo.com%3E et seq.
        Hide
        #asfinfra Bot added a comment -
        <danielsh> what is the use-case for this?
        Show
        #asfinfra Bot added a comment - <danielsh> what is the use-case for this?
        Hide
        Sebb added a comment - - edited
        Add "A" rating support
        Add c-s and c-i matching as per comments
        Remove tabs
        Tidy indentation

        This patch includes the previous patch

        N.B.
        It assumes that the comments in the badheaders control file are correct, i.e. h = case-insensitive, H = c-s
        If applied, the existing entries should perhaps be changed to use H as that is how they have been interpreted until now.
        Show
        Sebb added a comment - - edited Add "A" rating support Add c-s and c-i matching as per comments Remove tabs Tidy indentation This patch includes the previous patch N.B. It assumes that the comments in the badheaders control file are correct, i.e. h = case-insensitive, H = c-s If applied, the existing entries should perhaps be changed to use H as that is how they have been interpreted until now.
        Hide
        Sebb added a comment -
        Patch to implement "A" rating
        Show
        Sebb added a comment - Patch to implement "A" rating

          People

          • Assignee:
            Unassigned
            Reporter:
            Sebb
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development