Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: Initial Clearing
    • Component/s: Git
    • Labels:
      None

      Description

      The automatic forwarding of Github pull request notifications to relevant dev@ lists (see INFRA-3329) doesn't seem to work. I believe the functionality got broken recently when we changed github.com/apache from a normal account to an organization. I'll see what we can do to fix that.

        Activity

        Hide
        Jukka Zitting added a comment -
        Good catch, thanks! Added -oi in commit b04d867.
        Show
        Jukka Zitting added a comment - Good catch, thanks! Added -oi in commit b04d867.
        Hide
        #asfinfra IRC Bot added a comment -
        <danielsh> Don't you need to dotstuff $data ? or pass -oi ?
        Show
        #asfinfra IRC Bot added a comment - <danielsh> Don't you need to dotstuff $data ? or pass -oi ?
        Hide
        Jukka Zitting added a comment -
        Huh, finally fixed! Sorry about the delay on this.

        Figuring out the ports system proved too complex given the limited amount of cycles I had for this, so I opted instead to just replace the use of Mail::Message with a direct call to sendmail with an explicitly formatted mail message as input. We may encounter some encoding and/or line wrapping issues with this approach, but at least the basic functionality works again.
        Show
        Jukka Zitting added a comment - Huh, finally fixed! Sorry about the delay on this. Figuring out the ports system proved too complex given the limited amount of cycles I had for this, so I opted instead to just replace the use of Mail::Message with a direct call to sendmail with an explicitly formatted mail message as input. We may encounter some encoding and/or line wrapping issues with this approach, but at least the basic functionality works again.
        Hide
        #asfinfra IRC Bot added a comment -
        <danielsh> Do you need ports unblocked on the firewall or ports built on tb.a.o?
        Show
        #asfinfra IRC Bot added a comment - <danielsh> Do you need ports unblocked on the firewall or ports built on tb.a.o?
        Hide
        Jukka Zitting added a comment -
        Yes, reopening. I hadn't installed some of the Perl modules used by the notification system properly so they got lost in an update.

        Someone familiar with the FreeBSD ports system (or alternatively in setting up Perl modules as a part of a Git checkout) might be able to help here, as I'll be a bit busy with Incubator stuff for the next few days.
        Show
        Jukka Zitting added a comment - Yes, reopening. I hadn't installed some of the Perl modules used by the notification system properly so they got lost in an update. Someone familiar with the FreeBSD ports system (or alternatively in setting up Perl modules as a part of a Git checkout) might be able to help here, as I'll be a bit busy with Incubator stuff for the next few days.
        Hide
        Shazron Abdullah added a comment -
        Seems Github pull request notifications are not working again - I searched through the callback-dev list, it never received an email regarding this pull request yesterday: https://github.com/apache/incubator-cordova-ios/pull/6

        The last one received on the list was on Feb 27 2012, https://github.com/apache/incubator-cordova-android/pull/8
        Show
        Shazron Abdullah added a comment - Seems Github pull request notifications are not working again - I searched through the callback-dev list, it never received an email regarding this pull request yesterday: https://github.com/apache/incubator-cordova-ios/pull/6 The last one received on the list was on Feb 27 2012, https://github.com/apache/incubator-cordova-android/pull/8
        Hide
        Jukka Zitting added a comment -
        A restart was needed to activate an updated HMAC key, as without that the notifications were just being dropped. Now it's finally working as expected.
        Show
        Jukka Zitting added a comment - A restart was needed to activate an updated HMAC key, as without that the notifications were just being dropped. Now it's finally working as expected.
        Hide
        Jukka Zitting added a comment -
        Pull request notifications should now be working again.
        Show
        Jukka Zitting added a comment - Pull request notifications should now be working again.
        Hide
        Patrick Mueller added a comment -
        Someone just sent me a link to this, but haven't looked at it yet;

            http://alexking.org/blog/2011/11/28/not-getting-github-notifications
        Show
        Patrick Mueller added a comment - Someone just sent me a link to this, but haven't looked at it yet;      http://alexking.org/blog/2011/11/28/not-getting-github-notifications
        Hide
        Jukka Zitting added a comment -
        The existing pull request notification mechanism [1] was based on forwarding incoming notification emails from Github to the respective dev@ mailing lists. However, it looks like after we turned the github.com/apache account into an organization, those email notifications stopped, and AFAICT there's no way to re-enable them. To fix this I think we need to set up a pull_request hook on Github and have the hook generate and send the email notifications.

        [1] https://svn.apache.org/repos/infra/infrastructure/trunk/projects/git/bin/email-github.pl
        Show
        Jukka Zitting added a comment - The existing pull request notification mechanism [1] was based on forwarding incoming notification emails from Github to the respective dev@ mailing lists. However, it looks like after we turned the github.com/apache account into an organization, those email notifications stopped, and AFAICT there's no way to re-enable them. To fix this I think we need to set up a pull_request hook on Github and have the hook generate and send the email notifications. [1] https://svn.apache.org/repos/infra/infrastructure/trunk/projects/git/bin/email-github.pl
        Hide
        Shazron Abdullah added a comment -
        It happened with this pull-request as well from Becky Gibson https://github.com/apache/incubator-cordova-ios/pull/1
        Show
        Shazron Abdullah added a comment - It happened with this pull-request as well from Becky Gibson https://github.com/apache/incubator-cordova-ios/pull/1
        Hide
        Patrick Mueller added a comment -
        I believe you're referring to this pull request, which I made earlier today:

            https://github.com/apache/incubator-cordova-weinre/pull/1

        Could this have anything to do with my email address? I created this commit through to the GitHub web pages, and my default email address is my yahoo one, though apache is also another email address associated with my account.

        I'd never make a pull request like this for real - I'd always go through the command-line where my email address is set to the apache one.

        Let me know if you'd like me to try again, with the apache address.
        Show
        Patrick Mueller added a comment - I believe you're referring to this pull request, which I made earlier today:      https://github.com/apache/incubator-cordova-weinre/pull/1 Could this have anything to do with my email address? I created this commit through to the GitHub web pages, and my default email address is my yahoo one, though apache is also another email address associated with my account. I'd never make a pull request like this for real - I'd always go through the command-line where my email address is set to the apache one. Let me know if you'd like me to try again, with the apache address.

          People

          • Assignee:
            Jukka Zitting
            Reporter:
            Jukka Zitting
          • Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development