Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Fix Version/s: Initial Clearing
    • Component/s: Website
    • Labels:
      None

      Description

      The xsl transformation that sorts the names from the .rdf files does something wrong.
      My surname is "De Francisci Morales" but I end up being in the "M" list, while I should be in the "D" list.
      The script should not try to break up surnames around spaces.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1d 18h 35m 1 Gianmarco De Francisci Morales 04/Jan/12 09:31
        Resolved Resolved Closed Closed
        193d 5h 30m 1 #asfinfra Bot 15/Jul/12 15:02
        Gavin made changes -
        Fix Version/s Initial Clearing [ 12325964 ]
        #asfinfra Bot made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Tony Stevenson made changes -
        Workflow jira [ 12647526 ] INFRA Workflow [ 12711432 ]
        Gianmarco De Francisci Morales made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Gianmarco De Francisci Morales added a comment -
        Thanks, looks like everything is working now!
        Show
        Gianmarco De Francisci Morales added a comment - Thanks, looks like everything is working now!
        Hide
        Sebb added a comment -
        Forgot to return the selected data, which is why the output was empty ... hopefully now fixed.
        Show
        Sebb added a comment - Forgot to return the selected data, which is why the output was empty ... hopefully now fixed.
        Hide
        Sebb added a comment -
        Oops! not sure why there are no entries now - could not find any errors in the logs.
        Will investigate further.

        AFAICT, privateDetails.xsl is not used to generate the committers site; it is used by generateFoaflist.pl.

        nav.xsl is a utility stylesheet used by the other stylesheets in https://svn.apache.org/repos/asf/infrastructure/site/trunk/people/templates
        Show
        Sebb added a comment - Oops! not sure why there are no entries now - could not find any errors in the logs. Will investigate further. AFAICT, privateDetails.xsl is not used to generate the committers site; it is used by generateFoaflist.pl. nav.xsl is a utility stylesheet used by the other stylesheets in https://svn.apache.org/repos/asf/infrastructure/site/trunk/people/templates
        Hide
        Gianmarco De Francisci Morales added a comment -
        It looks like the list is gone now.
        Probably not the right fix.

        By the way, the snippet I pasted is from privateDetails.xsl and I don't know about nav.xls
        Show
        Gianmarco De Francisci Morales added a comment - It looks like the list is gone now. Probably not the right fix. By the way, the snippet I pasted is from privateDetails.xsl and I don't know about nav.xls
        Hide
        Sebb added a comment -
        Good catch - I've updated nav.xsl to remove the additional call to "substring-after-last".

        Let's see if this fixes the issue.
        Show
        Sebb added a comment - Good catch - I've updated nav.xsl to remove the additional call to "substring-after-last". Let's see if this fixes the issue.
        Hide
        Gianmarco De Francisci Morales added a comment -
        Hi,
        yes I am referring to those pages.

        The logic you describe is the one I would expect.
        However, I think there is an undue call to "substring-after-last" in the xsl.

        {code}
          <xsl:template match="foaf:Person" mode="sortWord">
            <xsl:variable name="word">
              <xsl:apply-templates select="." mode="lastName"/>
            </xsl:variable>
            <xsl:call-template name="substring-after-last">
              <xsl:with-param name="marker" select="' '"/>
              <xsl:with-param name="input" select="translate($word, 'abcdefghijklmnopqrstuvwxyz', 'ABCDEFGHIJKLMNOPQRSTUVWXYZ')"/>
            </xsl:call-template>
          </xsl:template>
        {code}

        I will try modifying the script and submitting a patch.
        Show
        Gianmarco De Francisci Morales added a comment - Hi, yes I am referring to those pages. The logic you describe is the one I would expect. However, I think there is an undue call to "substring-after-last" in the xsl. {code}   <xsl:template match="foaf:Person" mode="sortWord">     <xsl:variable name="word">       <xsl:apply-templates select="." mode="lastName"/>     </xsl:variable>     <xsl:call-template name="substring-after-last">       <xsl:with-param name="marker" select="' '"/>       <xsl:with-param name="input" select="translate($word, 'abcdefghijklmnopqrstuvwxyz', 'ABCDEFGHIJKLMNOPQRSTUVWXYZ')"/>     </xsl:call-template>   </xsl:template> {code} I will try modifying the script and submitting a patch.
        Hide
        Sebb added a comment -
        I assume that you are referring to the following pages?

        http://people.apache.org/committers.html
        and
        http://people.apache.org/list_M.html

        If so, I'm not sure why the sorting fails; as far as I can tell, the sort only uses tha last name if both the foaf:surname and foaf:family_name entries are missing.

        However, the generation process is rather complicated, so I could be missing something.
        Show
        Sebb added a comment - I assume that you are referring to the following pages? http://people.apache.org/committers.html and http://people.apache.org/list_M.html If so, I'm not sure why the sorting fails; as far as I can tell, the sort only uses tha last name if both the foaf:surname and foaf:family_name entries are missing. However, the generation process is rather complicated, so I could be missing something.
        Gianmarco De Francisci Morales created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Gianmarco De Francisci Morales
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development