Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: Initial Clearing
    • Component/s: Git
    • Labels:
      None

      Description

      There's some interest in experimenting with new Git workflows with Gerrit [1]. To do that, we need to install Gerrit on git.apache.org.

      [1] http://code.google.com/p/gerrit/

        Issue Links

          Activity

          Jukka Zitting created issue -
          Jukka Zitting made changes -
          Field Original Value New Value
          Link This issue is blocked by INFRA-2224 [ INFRA-2224 ]
          Hide
          Jukka Zitting added a comment -
          A test deployment of Gerrit is now available at http://git.apache.org:8080/. Let's see whether we can do anything useful with it.
          Show
          Jukka Zitting added a comment - A test deployment of Gerrit is now available at http://git.apache.org:8080/ . Let's see whether we can do anything useful with it.
          Jukka Zitting made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Jukka Zitting [ jukkaz ]
          Resolution Fixed [ 1 ]
          Tony Stevenson made changes -
          Workflow jira [ 12474748 ] INFRA Workflow [ 12716025 ]
          #asfinfra IRC Bot made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Nick Dimiduk added a comment -
          Is this an active endeavor? I happen to like gerrit much more than review board. At the very least, nothing responds on port 8080...
          Show
          Nick Dimiduk added a comment - Is this an active endeavor? I happen to like gerrit much more than review board. At the very least, nothing responds on port 8080...
          Hide
          Sergey Shelukhin added a comment -
          +1 on JIRA... should it be reopened?
          Show
          Sergey Shelukhin added a comment - +1 on JIRA... should it be reopened?
          Hide
          Jukka Zitting added a comment -
          We didn't find much interest for it back in 2010 or later. If/when there is interest from at least a few project communities and a handful of long-term volunteers to maintain the service we might reconsider setting it up again.
          Show
          Jukka Zitting added a comment - We didn't find much interest for it back in 2010 or later. If/when there is interest from at least a few project communities and a handful of long-term volunteers to maintain the service we might reconsider setting it up again.
          Hide
          Nick Dimiduk added a comment -
          I'd like to have Gerrit up for (HBase) reviews. Who can I help to make this a reality?
          Show
          Nick Dimiduk added a comment - I'd like to have Gerrit up for (HBase) reviews. Who can I help to make this a reality?
          Hide
          Jacques Nadeau added a comment -
          We'd be interested from the Drill community in helping make this happen.

          Show
          Jacques Nadeau added a comment - We'd be interested from the Drill community in helping make this happen.
          Hide
          Sergey Shelukhin added a comment -
          HBase was also considering it again, but it will be some time before we can use it (need to switch to git first)
          Show
          Sergey Shelukhin added a comment - HBase was also considering it again, but it will be some time before we can use it (need to switch to git first)
          Hide
          Yuri Zelikov added a comment -
          I think we - at Apache Wave - could use Gerrit for code reviews. Is this a real option?
          Show
          Yuri Zelikov added a comment - I think we - at Apache Wave - could use Gerrit for code reviews. Is this a real option?
          Hide
          Jake Farrell added a comment -
          Reviewboard is available at reviews.apache.org, but Gerrit is not an option currently.
          Show
          Jake Farrell added a comment - Reviewboard is available at reviews.apache.org, but Gerrit is not an option currently.
          Hide
          James Taylor added a comment -
          Apache Phoenix is interested in Gerrit as well. I think as the Github model of development has become more popular, tools like Gerrit that support a similar model are in higher demand.

          Looks like HBase, Drill, Phoenix, and Wave are all interested. Is that enough [~jfarrell]?
          Show
          James Taylor added a comment - Apache Phoenix is interested in Gerrit as well. I think as the Github model of development has become more popular, tools like Gerrit that support a similar model are in higher demand. Looks like HBase, Drill, Phoenix, and Wave are all interested. Is that enough [~jfarrell]?
          Hide
          Jake Farrell added a comment -
          All requests infra has received for code review like this have been for Reviewboard and only the projects mentioned on this ticket have inquired about Gerrit. We may consider revisiting this when the git-wip to git.a.o migration is completed, but Reviewboard is the current preferred system and there are no plans in the near term to set Gerrit up.
          Show
          Jake Farrell added a comment - All requests infra has received for code review like this have been for Reviewboard and only the projects mentioned on this ticket have inquired about Gerrit. We may consider revisiting this when the git-wip to git.a.o migration is completed, but Reviewboard is the current preferred system and there are no plans in the near term to set Gerrit up.
          Hide
          Nick Dimiduk added a comment -
          Hi [~jfarrell]. The interest in Gerrit is in supporting a git workflow that is managed by code review. Specifically, the desire is for pre-commits to be reviewed by developers and a QABot. The commits themselves would be gated by the review system, requiring both a clean QA run and +1 from pre-commit review before being applied to the master/development branch. This can also be used to enforce the linear application of commits to the master/development branch (ie, fast-forward commits only, no merges).

          Is this kind of workflow possible via ReviewBoard? It's not obvious to me from the project documentation. Thanks a lot for your time!
          Show
          Nick Dimiduk added a comment - Hi [~jfarrell]. The interest in Gerrit is in supporting a git workflow that is managed by code review. Specifically, the desire is for pre-commits to be reviewed by developers and a QABot. The commits themselves would be gated by the review system, requiring both a clean QA run and +1 from pre-commit review before being applied to the master/development branch. This can also be used to enforce the linear application of commits to the master/development branch (ie, fast-forward commits only, no merges). Is this kind of workflow possible via ReviewBoard? It's not obvious to me from the project documentation. Thanks a lot for your time!
          Hide
          Yuri Zelikov added a comment -
          Review board is a bit laggy/slow and also has issues with binary patches (that includes jars)
          Show
          Yuri Zelikov added a comment - Review board is a bit laggy/slow and also has issues with binary patches (that includes jars)
          Hide
          Jake Farrell added a comment -
          right now the precommit testing is only available via jira and the patch available state. I am looking into how we can have a similar flow from within reviewboard to jenkins for pre-patch verification. There are no flow in which a committer can auto-commit directly from reviewboard or jira.

          I upgraded reviewboard and patched python threading on the machine it runs on this week to address the laggy/slow issues that have been causing the 502's recently. So far I have not had any reports of issues since the upgrades.
          Show
          Jake Farrell added a comment - right now the precommit testing is only available via jira and the patch available state. I am looking into how we can have a similar flow from within reviewboard to jenkins for pre-patch verification. There are no flow in which a committer can auto-commit directly from reviewboard or jira. I upgraded reviewboard and patched python threading on the machine it runs on this week to address the laggy/slow issues that have been causing the 502's recently. So far I have not had any reports of issues since the upgrades.
          Gavin made changes -
          Fix Version/s Initial Clearing [ 12325964 ]

            People

            • Assignee:
              Jukka Zitting
              Reporter:
              Jukka Zitting
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development