[INFRA-21041] GitHub "review comments" not emailed to mailing list

• Type: Planned Work
• Status: Waiting for user
• Priority: Major
• Resolution: Unresolved
• Component/s: GitBox, Github, Mailing Lists
• Project: Incubator
• Assignee: Daniel Gruno
• Reporter: Steve Lawrence
• Created: 28/Oct/20 15:52
• Updated: 03/Feb/21 16:38
• Review Date: 29/Oct/20

Description

When finishing a code review on GitHub (i.e. go to a Pull Request > Files changed tab > Review Changes button > Leave a comment > Submit Review), I've noticed that the Daffodil project hasn't recently received emails containing that comment. We get emails for comments made in-line in the PR code, and we get emails about comments made in the "conversation" tab in a PR, but we don't get the emails about the Review Changes comments.

For example, in this pull request:

https://github.com/apache/incubator-daffodil/pull/444

We can find Mike Beckerle's in-line comment about "The JIRA ticket has a small test...":

https://lists.apache.org/thread.html/r3f0b951cf8c3e79d04a73387799d38765914467f713f99a926ae26dd%40%3Ccommits.daffodil.apache.org%3E

We can find Steve Lawrence's top-level comment about
"Does this also mean that there is a bug..."

https://lists.apache.org/thread.html/r61b333a36815a8c3eb04253747892d9ee779318e1a940aaed35d6bf1%40%3Ccommits.daffodil.apache.org%3E

But we can't find Mike Beckerle's review changes comment "Please add the test":

https://lists.apache.org/list.html?[e-mail]:lte=1M:%22Please%20add%20the%20test%22

Or Mike Beckerle's review changes comment "+1 if full regression on all known schemas works."

https://lists.apache.org/list.html?[e-mail]:lte=1M:%22on%20all%20known%20schemas%20works.%22

We often include our "+1"s in this "review changes" comment, so right now we don't currently have any tracking of these in our mailing list.