Uploaded image for project: 'Infrastructure'
  1. Infrastructure
  2. INFRA-19297

Consolidate PR review comments into one email per review

    XMLWordPrintableJSON

    Details

    • Type: Planned Work
    • Status: Waiting for Infra
    • Priority: Major
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: GitBox
    • Project:
      Incubator

      Description

      The issues.cgi script receives callbacks from GitHub webhooks for various events.

      It is common for a PR reviewer to add code-related comments to 30 different code fragments for the same review, and then wrap it up with an overall comment.

      GitHub's email notifications will then send you *one* email with the review comment followed by all the individual code snippets with comments.

      However, when GitBox sends notifications from issues.cgi to project mailing list, it will send 30 individual emails to the list, one for each code fragment, and *not* send any notification at all for the overall PR review comment.

      Also, if GitBox sent these as HTML email similar to that in GitHub emails, it would be easier on the eyes to consume the emails since code would have different font and color than comments etc.

        Attachments

        1. pr-review-callbacks.jsonl
          98 kB
          Jan Høydahl

          Activity

            People

            • Assignee:
              humbedooh Daniel Gruno
              Reporter:
              janhoy Jan Høydahl
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Review Date: