Uploaded image for project: 'Infrastructure'
  1. Infrastructure
  2. INFRA-15466

Move OFBiz rat-excludes.txt from trunk to tools branch

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: Buildbot
    • Labels:
      None
    • Project:
      OFBiz

      Description

      At INFRA-15395 we added a rat-excludes.txt files http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/rat-excludes.txt?view=markup in OFBiz trunk root dir. We want now to move it into http://svn.apache.org/viewvc/ofbiz/tools/

      TIA

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment - Reporter
        Thanks a lot Gavin,

        I did not thought about export :/
        Show
        jacques.le.roux Jacques Le Roux added a comment - Reporter Thanks a lot Gavin, I did not thought about export :/
        Hide
        gmcdonald Gavin added a comment -
        Ok fixed after a few attempts.

        Added this command to your ofbiz.conf file

        +_ofb_rat_trunk.addStep(ShellCommand(name="Export", command=["svn", "export", "--", "https://svn.apache.org/repos/asf/ofbiz/tools/rat-excludes.txt", "rat-excludes.txt"],

        That checks out the single file from the tools repo and places it into your trunk repo, making it work the same as before.

        See results at:

        https://ci.apache.org/projects/ofbiz/rat-output.html

        Down to 5 unlicensed files, very good!

        Show
        gmcdonald Gavin added a comment - Ok fixed after a few attempts. Added this command to your ofbiz.conf file +_ofb_rat_trunk.addStep(ShellCommand(name="Export", command=["svn", "export", "--", " https://svn.apache.org/repos/asf/ofbiz/tools/rat-excludes.txt ", "rat-excludes.txt"], That checks out the single file from the tools repo and places it into your trunk repo, making it work the same as before. See results at: https://ci.apache.org/projects/ofbiz/rat-output.html Down to 5 unlicensed files, very good!
        Hide
        gmcdonald Gavin added a comment -
        Sorry, will take a look later today.
        Show
        gmcdonald Gavin added a comment - Sorry, will take a look later today.
        Hide
        jacques.le.roux Jacques Le Roux added a comment - Reporter
        Hi Gavin, any chances here?
        Show
        jacques.le.roux Jacques Le Roux added a comment - Reporter Hi Gavin, any chances here?
        Hide
        jacques.le.roux Jacques Le Roux added a comment - Reporter
        I was thinking: previously you used a temporary file in buildbot_slave/files/ofbiz.xml. So maybe simply copying (wget?) the rat-exclude.txt file from the tools branch in this place would work?
        Show
        jacques.le.roux Jacques Le Roux added a comment - Reporter I was thinking: previously you used a temporary file in buildbot_slave/files/ofbiz.xml. So maybe simply copying (wget?) the rat-exclude.txt file from the tools branch in this place would work?
        Hide
        gmcdonald Gavin added a comment -
        ok no problem I'll take a look.
        Show
        gmcdonald Gavin added a comment - ok no problem I'll take a look.
        Hide
        jacques.le.roux Jacques Le Roux added a comment - Reporter
        HI Gavin,

        I desesperately tried to find a way but I must say I did not find a solution using the ofbiz.conf file. After using wget to get the rat-exclude.txt file from the tools branch, which does not work, I ultimately thought about using the svn interpolate https://docs.buildbot.net/latest/manual/cfg-buildsteps.html#svn But I'm not sure in this case it's better than simply checking the whole ofbiz repo http://svn.apache.org/viewvc/ofbiz/. Maybe using and svn incremental checkout or mode like fresh or copy would help. But in any case it finally seems to me that changing the buildbot_slave/files/ofbiz.xml would be better. But then I don't clearly understand how to refer to the tools branch there :/

        So yes help is wanted :)
        Show
        jacques.le.roux Jacques Le Roux added a comment - Reporter HI Gavin, I desesperately tried to find a way but I must say I did not find a solution using the ofbiz.conf file. After using wget to get the rat-exclude.txt file from the tools branch, which does not work, I ultimately thought about using the svn interpolate https://docs.buildbot.net/latest/manual/cfg-buildsteps.html#svn But I'm not sure in this case it's better than simply checking the whole ofbiz repo http://svn.apache.org/viewvc/ofbiz/ . Maybe using and svn incremental checkout or mode like fresh or copy would help. But in any case it finally seems to me that changing the buildbot_slave/files/ofbiz.xml would be better. But then I don't clearly understand how to refer to the tools branch there :/ So yes help is wanted :)
        Hide
        gmcdonald Gavin added a comment -
        I see you have been changing your ofbiz.conf file.

        Let me know if you need anything doing, otherwise I'll wait for your PR
        Show
        gmcdonald Gavin added a comment - I see you have been changing your ofbiz.conf file. Let me know if you need anything doing, otherwise I'll wait for your PR
        Hide
        jacques.le.roux Jacques Le Roux added a comment - Reporter
        OK, while working on other stuff I found
        https://github.com/apache/infrastructure-puppet/blob/deployment/modules/buildbot_slave/files/ofbiz.xml
        I'll look at it and I guess create a PR :)
        Show
        jacques.le.roux Jacques Le Roux added a comment - Reporter OK, while working on other stuff I found https://github.com/apache/infrastructure-puppet/blob/deployment/modules/buildbot_slave/files/ofbiz.xml I'll look at it and I guess create a PR :)

          People

          • Assignee:
            gmcdonald Gavin
            Reporter:
            jacques.le.roux Jacques Le Roux
            Request participants:
            None
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Review Date: