Uploaded image for project: 'Infrastructure'
  1. Infrastructure
  2. INFRA-15233

Marking the master branch of "incubator-mxnet" protected

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: Git, Github
    • Labels:
      None
    • Project:
      Incubator

      Description

      Hi,

      Community has decided to mark the master branch of incubator-mxnet repo to be protected.
      We all agreed on protected branch feature mentioned in https://help.github.com/articles/about-protected-branches/.

      Appreciate your help.

      Regards,
      Gautam
      1. mxnet.png
        112 kB
        Daniel Takamori

        Activity

        Hide
        pono Daniel Takamori added a comment - - edited
        Master branch is already protected, are there other options you'd like set? !https://home.apache.org/~pono/mxnet.png
        Show
        pono Daniel Takamori added a comment - - edited Master branch is already protected, are there other options you'd like set? ! https://home.apache.org/~pono/mxnet.png
        Hide
        gautamkmr Gautam Kumar added a comment - Reporter
        [~pono] Thanks for quick response.

        Sorry I was not aware the fact that master branch of incubator-mxnet is protected. Would you be able to confirm that all the feature listed in the https://help.github.com/articles/about-protected-branches/ has been set ?
        We wanted a very important feature where "Can't have changes merged into it until required status checks pass" and the required status checks are "Jenkins and appveyor checks have succeeded.
        Show
        gautamkmr Gautam Kumar added a comment - Reporter [~pono] Thanks for quick response. Sorry I was not aware the fact that master branch of incubator-mxnet is protected. Would you be able to confirm that all the feature listed in the https://help.github.com/articles/about-protected-branches/ has been set ? We wanted a very important feature where "Can't have changes merged into it until required status checks pass" and the required status checks are "Jenkins and appveyor checks have succeeded.
        Hide
        pono Daniel Takamori added a comment -
        See the image I linked and tell me exactly which you would like turned on/ off.
        Show
        pono Daniel Takamori added a comment - See the image I linked and tell me exactly which you would like turned on/ off.
        Hide
        gautamkmr Gautam Kumar added a comment - Reporter
        Please check all the four bottom-most check box.
        continuous-integeration/appveyor/branch
        continuous-integeration/appveyor/pr
        continuous-integeration/jenkins/branch
        continuous-integeration/jenkins/pr



        Show
        gautamkmr Gautam Kumar added a comment - Reporter Please check all the four bottom-most check box. continuous-integeration/appveyor/branch continuous-integeration/appveyor/pr continuous-integeration/jenkins/branch continuous-integeration/jenkins/pr
        Hide
        pono Daniel Takamori added a comment -
        Done :)
        Show
        pono Daniel Takamori added a comment - Done :)
        Hide
        gautamkmr Gautam Kumar added a comment - Reporter
        Thanks. Just realize that we dont need "Require branches to be up to date before merging"

        Can we please un check the box "Require branches to be up to date before merging" ?
        Show
        gautamkmr Gautam Kumar added a comment - Reporter Thanks. Just realize that we dont need "Require branches to be up to date before merging" Can we please un check the box "Require branches to be up to date before merging" ?
        Hide
        gautamkmr Gautam Kumar added a comment - Reporter
        I have spin off a new JIRA here https://issues.apache.org/jira/browse/INFRA-15267.
        Thanks.
        Show
        gautamkmr Gautam Kumar added a comment - Reporter I have spin off a new JIRA here https://issues.apache.org/jira/browse/INFRA-15267 . Thanks.
        Hide
        gautamkmr Gautam Kumar added a comment - - edited Reporter
        Since INFRA-15267 has been closed writing it here.

        Uncheck
        1. "Require branches to be up to date before merging"
        2. "continuous-integeration/appveyor/pr"
        3. "continuous-integeration/jenkins/pr"

        Check:
        1. Check "Require pull request reviews before merging"
        Show
        gautamkmr Gautam Kumar added a comment - - edited Reporter Since INFRA-15267 has been closed writing it here. Uncheck 1. "Require branches to be up to date before merging" 2. "continuous-integeration/appveyor/pr" 3. "continuous-integeration/jenkins/pr" Check: 1. Check "Require pull request reviews before merging"
        Hide
        gautamkmr Gautam Kumar added a comment - Reporter
        Reopening to get the assignment.
        Show
        gautamkmr Gautam Kumar added a comment - Reporter Reopening to get the assignment.
        Hide
        gautamkmr Gautam Kumar added a comment - Reporter
        Apologize to re-opening this to follow up on below change.

        *Uncheck*
        1. "Require branches to be up to date before merging"
        2. "continuous-integeration/appveyor/pr"
        3. "continuous-integeration/jenkins/pr"

        *Check*:
        1. Check "Require pull request reviews before merging"
        Show
        gautamkmr Gautam Kumar added a comment - Reporter Apologize to re-opening this to follow up on below change. *Uncheck* 1. "Require branches to be up to date before merging" 2. "continuous-integeration/appveyor/pr" 3. "continuous-integeration/jenkins/pr" *Check*: 1. Check "Require pull request reviews before merging"
        Hide
        pono Daniel Takamori added a comment -
        Thanks for reopening instead of making a new ticket like 15267. I posted a picture of all the options and this is the third time I've had to change something. Are you sure this is the last thing you need changed?
        Show
        pono Daniel Takamori added a comment - Thanks for reopening instead of making a new ticket like 15267. I posted a picture of all the options and this is the third time I've had to change something. Are you sure this is the last thing you need changed?
        Hide
        gautamkmr Gautam Kumar added a comment - Reporter
        I apologize for confusion, Is it possible for you to post a picture of current setting to avoid further confusion?

        From what I know based on our previous setting, below list should be un-checked.

        *Uncheck*
        "continuous-integeration/appveyor/branch"
        "continuous-integeration/jenkins/branch"
        "Require branches to be up to date before merging"

        Thanks again.
        Show
        gautamkmr Gautam Kumar added a comment - Reporter I apologize for confusion, Is it possible for you to post a picture of current setting to avoid further confusion? From what I know based on our previous setting, below list should be un-checked. *Uncheck* "continuous-integeration/appveyor/branch" "continuous-integeration/jenkins/branch" "Require branches to be up to date before merging" Thanks again.
        Hide
        pono Daniel Takamori added a comment -
        here's the current branch protections
        Show
        pono Daniel Takamori added a comment - here's the current branch protections
        Hide
        gautamkmr Gautam Kumar added a comment - Reporter
        Did you attach anything ? I cant find anything here.

        Show
        gautamkmr Gautam Kumar added a comment - Reporter Did you attach anything ? I cant find anything here.
        Hide
        pono Daniel Takamori added a comment -
        There's an attachment under the description: https://issues.apache.org/jira/secure/attachment/12891784/mxnet.png
        Show
        pono Daniel Takamori added a comment - There's an attachment under the description: https://issues.apache.org/jira/secure/attachment/12891784/mxnet.png
        Hide
        gautamkmr Gautam Kumar added a comment - Reporter
        Thank you.

         Please un check the following two.
        "continuous-integeration/appveyor/branch"
        "continuous-integeration/jenkins/branch"

        Thanks again for your patient and help. Much appreciated.
        Show
        gautamkmr Gautam Kumar added a comment - Reporter Thank you.  Please un check the following two. "continuous-integeration/appveyor/branch" "continuous-integeration/jenkins/branch" Thanks again for your patient and help. Much appreciated.
        Hide
        pono Daniel Takamori added a comment -
        Done.
        Show
        pono Daniel Takamori added a comment - Done.
        Hide
        gautamkmr Gautam Kumar added a comment - Reporter
        Awesome Thank you so much :)
        Show
        gautamkmr Gautam Kumar added a comment - Reporter Awesome Thank you so much :)

          People

          • Assignee:
            pono Daniel Takamori
            Reporter:
            gautamkmr Gautam Kumar
            Request participants:
            None
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: