Uploaded image for project: 'Infrastructure'
  1. Infrastructure
  2. INFRA-14856

lists.a.o: corrupted favourites preference

    Details

      Description

      The json returned by https://lists.apache.org/api/preferences.lua when I am logged in includes the following:

      "favorites":[null,null,null]

      I cannot remove it using the GUI.
      Also I don't see any entries in the '*' tab on the front page even if I add some favourites.

      Please can someone remove the null entries? Thanks.

        Activity

        Hide
        humbedooh Daniel Gruno added a comment -
        Looks like a transient caching issue happened during a maintenance cycle. I'm not seeing any evidence of this being a problem any longer.
        Show
        humbedooh Daniel Gruno added a comment - Looks like a transient caching issue happened during a maintenance cycle. I'm not seeing any evidence of this being a problem any longer.
        Hide
        sebb@apache.org Sebb added a comment - Reporter
        The problem is still present.
        I've just logged in on a different computer and I see the attached.
        Show
        sebb@apache.org Sebb added a comment - Reporter The problem is still present. I've just logged in on a different computer and I see the attached.
        Hide
        sebb@apache.org Sebb added a comment - Reporter
        I forgot to add that this has been an issue for at least a year; I only just got around to reporting it.

        Also when I was reporting it I tried various URLs to see if I could delete the entry.
        I did not succeed in deleting any nulls, but I did manage to create another one...
        Show
        sebb@apache.org Sebb added a comment - Reporter I forgot to add that this has been an issue for at least a year; I only just got around to reporting it. Also when I was reporting it I tried various URLs to see if I could delete the entry. I did not succeed in deleting any nulls, but I did manage to create another one...
        Hide
        humbedooh Daniel Gruno added a comment -
        I think the problem resides in the garbage collection inside the favorites list. I've asked for a fix of the issue.
        Show
        humbedooh Daniel Gruno added a comment - I think the problem resides in the garbage collection inside the favorites list. I've asked for a fix of the issue.
        Hide
        sebb@apache.org Sebb added a comment - Reporter
        There are two aspects to this:
        1) Ponymail code should not allow nulls to be added to the entry
        2) Any existing nulls need to be removed
        Show
        sebb@apache.org Sebb added a comment - Reporter There are two aspects to this: 1) Ponymail code should not allow nulls to be added to the entry 2) Any existing nulls need to be removed
        Hide
        humbedooh Daniel Gruno added a comment -
        Yep, and the problem lies in that the GC doesn't kick in before the changes are saved, due to how the fav manipulation happens at the moment.
        https://github.com/apache/incubator-ponymail/blob/master/site/api/preferences.lua#L256 needs to be replaced with a table.remove+break call instead, but also when fetching the list (at least for now), null entries need to be weeded out.
        Show
        humbedooh Daniel Gruno added a comment - Yep, and the problem lies in that the GC doesn't kick in before the changes are saved, due to how the fav manipulation happens at the moment. https://github.com/apache/incubator-ponymail/blob/master/site/api/preferences.lua#L256 needs to be replaced with a table.remove+break call instead, but also when fetching the list (at least for now), null entries need to be weeded out.
        Hide
        sebb@apache.org Sebb added a comment - Reporter
        So there is a bug in preferences.lua.
        An issue should be raised against Ponymail and then a fix can be added.
        Show
        sebb@apache.org Sebb added a comment - Reporter So there is a bug in preferences.lua. An issue should be raised against Ponymail and then a fix can be added.
        Hide
        sebb@apache.org Sebb added a comment - Reporter
        Seems to have been fixed now for me
        Show
        sebb@apache.org Sebb added a comment - Reporter Seems to have been fixed now for me

          People

          • Assignee:
            humbedooh Daniel Gruno
            Reporter:
            sebb@apache.org Sebb
            Request participants:
            None
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: