[IMPALA-9849] Set halt_on_error=1 for TSAN builds

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Impala 4.0.0
• Epic Color: ghx-label-2
• Assignee: Sahil Takiar
• Reporter: Sahil Takiar
• Created: 11/Jun/20 17:45
• Updated: 22/Jun/20 20:16
• Resolved: 22/Jun/20 20:16

Description

IMPALA-9568 mistakingly removed the halt_on_error flag from TSAN builds. The intention in IMPALA-9568 was to make sure that Impala crashes when a TSAN bug is detected, Impala does this for ASAN builds already. The confusing part about halt_on_error is that by default it is true in ASAN builds, but by default it is false in TSAN builds. So halt_on_error needs to explicitly be set to true for TSAN builds (but not for ASAN builds).

Issue Links

• is caused by: IMPALA-9568 Template tuples are initialized multiple times