[IMPALA-9732] Improve exceptions of unsupported HdfsTableSink formats

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 3.4.0
• Fix Version/s: Impala 4.0.0
• Component/s: Frontend
• Epic Color: ghx-label-2
• Assignee: Tamas Mate
• Reporter: Tamas Mate
• Created: 07/May/20 10:24
• Updated: 20/Apr/21 10:40
• Resolved: 20/Apr/21 10:40

Description

For unsupported table writes an IllegalStateException is thrown during planning here:

 Preconditions.checkState(false, "Unsupported TableSink format(s): " + Joiner.on(',').join(unsupportedFormats));

This exception could be improved by changing the IllegalStateException to a more meaningful one and the "TableSink format" to a term which is familiar for the users.

Additionally, the exception is thrown generally when a table has a partition with unsupported format, dynamic partitioning is not taken into consideration. The check could be extended to only throw exception when the partition that is being written is unsupported.