Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-9623

Replace architecture-specific atomics with C++11 atomics

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • Backend
    • ghx-label-9

    Description

      The atomic operations in gutil/ use inline assembly for each architecture. Chromium, which is the upstream for gutil, has switched to generic atomic operations instead: https://github.com/chromium/chromium/blob/2ca8c5037021c9d2ecc00b787d58a31ed8fc8bcb/base/atomicops.h#L152

       

      It would be nice to make the corresponding change and make our codebase more portable. I did a dry run of this and ran into some minor issues with compiling, but it looked feasible. I'll attach here: 0001-WIP-on-generic-atomics.-Not-compiling-yet.patch

      Attachments

        Activity

          People

            Unassigned Unassigned
            tarmstrong Tim Armstrong
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: