[IMPALA-9534] Kudu show create table tests fail due to case difference for external.table.purge

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: Impala 4.0.0
• Fix Version/s: Impala 4.0.0
• Component/s: Frontend
• Labels: broken-build
• Target Version: Impala 4.0.0
• Epic Color: ghx-label-1
• Assignee: Sahil Takiar
• Reporter: Joe McDonnell
• Created: 19/Mar/20 16:19
• Updated: 19/May/20 19:37
• Resolved: 19/May/20 19:37

Description

When updating to the latest CDP GBN, there are test failures due to our tests expecting external.table.purge=TRUE (upper case) whereas it is actually external.table.purge=true (lower case):

 

query_test/test_kudu.py:862: in test_primary_key_and_distribution
    db=cursor.conn.db_name, kudu_addr=KUDU_MASTER_HOSTS))
query_test/test_kudu.py:836: in assert_show_create_equals
    assert "TBLPROPERTIES ('external.table.purge'='TRUE', " in output
E   assert "TBLPROPERTIES ('external.table.purge'='TRUE', " in "CREATE EXTERNAL TABLE testshowcreatetable_6928_i0obd1.jlxsrpzmcu (\n  c INT NOT NULL ENCODING AUTO_ENCODING COMPRESSI...H (c) PARTITIONS 3\nSTORED AS KUDU\nTBLPROPERTIES ('external.table.purge'='true', 'kudu.master_addresses'='localhost')"

This impacts the following tests:

 

 

metadata.test_ddl.TestDdlStatements.test_create_alter_tbl_properties
metadata.test_show_create_table.TestShowCreateTable.test_show_create_table
query_test.test_kudu.TestShowCreateTable.test_primary_key_and_distribution
query_test.test_kudu.TestShowCreateTable.test_timestamp_default_value
query_test.test_kudu.TestShowCreateTable.test_managed_kudu_table_name_with_show_create
org.apache.impala.catalog.local.LocalCatalogTest.testKuduTable

I think we can just make these case insensitive.