[IMPALA-9505] CatalogdMetaProvider using bad TUnit for profile counters

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: Frontend
• Labels: observability
• Epic Color: ghx-label-6
• Assignee: Unassigned
• Reporter: David Rorke
• Created: 13/Mar/20 23:05
• Updated: 13/Mar/20 23:06

Description

CatalogdMetaProvider is using a TUnit value of TUnit.NONE for several runtime profile counters:

https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java#L554-L558

and

https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java#L387

TUnit.UNIT would be a better choice here and the use of TUnit.NONE may break existing profile readers which won't expect this value for a numerical counter.  The appropriate set of TUnit types to maximize reader compatibility is described in IMPALA-8236.