[IMPALA-9398] When pressing Ctrl+C the content of the shell history gets doubled

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Resolved
• Affects Version/s: Impala 3.3.0
• Fix Version/s: Impala 4.0.0, Impala 3.4.1
• Component/s: Clients
• Labels: impala-shell ramp-up
• Epic Color: ghx-label-10
• Assignee: Tamas Mate
• Reporter: Adam Tamas
• Created: 18/Feb/20 13:51
• Updated: 05/Feb/21 13:21
• Resolved: 11/May/20 14:02

Description

If Ctrl+C was pressed in the impala-shell, the content of the ~/.impalahistory got copied into the end of the file for each instance the Ctrl+C was pressed.

The new queries written while the shell was open is not duplicated and the file is only updated after the impala-shell was closed.

Example:

$ rm ~/.impalahistory

$ impala-shell.sh
impala> select 1;
impala> select 2;
impala> quit;

$ cat -n ~/.impalahistory
1 select 1;
2 select 2;
3 quit;

$ impala-shell.sh
impala> ^C
impala> quit;

$ cat -n ~/.impalahistory
1 select 1;
2 select 2;
3 quit;
4 select 1;
5 select 2;
6 quit;

The second impala-shell session, Ctrl-C doubled all the history entries.