[IMPALA-9312] run_clang_tidy.sh hides errors in buildall.sh

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Impala 3.4.0
• Component/s: Infrastructure
• Epic Color: ghx-label-2
• Assignee: Tim Armstrong
• Reporter: Tim Armstrong
• Created: 22/Jan/20 01:12
• Updated: 22/Jan/20 20:44
• Resolved: 22/Jan/20 20:44

Description

https://jenkins.impala.io/job/clang-tidy-ub1604/10706/ just failed with this unhelpful error:

Compiling
WARNING: compile failed
run-clang-tidy.py hit an error, dumping stderr output
bin/run_clang_tidy.sh: line 59: run-clang-tidy.py: command not found
 

It seems like the toolchain download failed, but we have no way to debug further. We should at least dump the output of buildall.sh. It would probably be better if we treated buildall.sh failures as a hard failure.