[IMPALA-8908] Bad error message when failing to connect to HTTPS endpoint with shell

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Impala 3.3.0
• Fix Version/s: Impala 4.0.0
• Component/s: Clients
• Labels: observability ramp-up
• Target Version: Impala 4.0.0
• Epic Color: ghx-label-4
• Assignee: Tamas Mate
• Reporter: Tim Armstrong
• Created: 29/Aug/19 00:27
• Updated: 11/May/20 15:58
• Resolved: 11/May/20 15:58

Description

Legitimate connection errors get masked with an UnboundLocalError. It looks like THRIFT-3634 fixed this.

$ impala-shell.sh -i ip-10-97-80-186.cloudera.site --protocol=hs2 --ldap --user csso_tarmstrong --ssl
Starting Impala Shell using LDAP-based authentication
SSL is enabled. Impala server certificates will NOT be verified (set --ca_cert to change)
LDAP password for csso_tarmstrong:
Traceback (most recent call last):
  File "/home/tarmstrong/Impala/incubator-impala/shell/impala_shell.py", line 1880, in <module>
    impala_shell_main()
  File "/home/tarmstrong/Impala/incubator-impala/shell/impala_shell.py", line 1841, in impala_shell_main
    with ImpalaShell(options, query_options) as shell:
  File "/home/tarmstrong/Impala/incubator-impala/shell/impala_shell.py", line 243, in __init__
    self.do_connect(options.impalad)
  File "/home/tarmstrong/Impala/incubator-impala/shell/impala_shell.py", line 812, in do_connect
    self._connect()
  File "/home/tarmstrong/Impala/incubator-impala/shell/impala_shell.py", line 860, in _connect
    self.server_version, self.webserver_address = self.imp_client.connect()
  File "/home/tarmstrong/Impala/incubator-impala/shell/impala_client.py", line 176, in connect
    self.transport = self._get_transport(self.client_connect_timeout_ms)
  File "/home/tarmstrong/Impala/incubator-impala/shell/impala_client.py", line 472, in _get_transport
    transport.open()
  File "/home/tarmstrong/Impala/incubator-impala/shell/thrift_sasl.py", line 61, in open
    self._trans.open()
  File "/opt/Impala-Toolchain/thrift-0.9.3-p7/python/lib/python2.7/site-packages/thrift/transport/TSSLSocket.py", line 258, in open
    logger.error('Error while connecting with %s.', ip_port, exc_info=True)
UnboundLocalError: local variable 'ip_port' referenced before assignment

Issue Links

• is part of: IMPALA-9489 Setup impala-shell.sh env separately, and use thrift-0.11.0 by default