[IMPALA-8799] Prometheus metrics should be prefixed with "impala_"

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Impala 3.3.0
• Component/s: Backend
• Labels: observability
• Target Version: Impala 3.3.0
• Epic Color: ghx-label-1
• Assignee: Tim Armstrong
• Reporter: Tim Armstrong
• Created: 28/Jul/19 00:49
• Updated: 29/Jul/19 17:56
• Resolved: 29/Jul/19 06:53

Description

This is recommended by the Prometheus docs - https://prometheus.io/docs/practices/naming/

A metric name...

...must comply with the data model for valid characters.
...should have a (single-word) application prefix relevant to the domain the metric belongs to. The prefix is sometimes referred to as namespace by client libraries. For metrics specific to an application, the prefix is usually the application name itself. Sometimes, however, metrics are more generic, like standardized metrics exported by client libraries. Examples:
prometheus_notifications_total (specific to the Prometheus server)
process_cpu_seconds_total (exported by many client libraries)
http_request_duration_seconds (for all HTTP requests)

It is also awkward in tools like grafana to find impala metrics with the current naming scheme.