[IMPALA-8652] Illegal delimiter error in shell has "unknown exception" as part of error message

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 3.3.0
• Component/s: Clients
• Labels: newbie ramp-up
• Target Version: Product Backlog
• Epic Color: ghx-label-4
• Assignee: Jiawei Wang
• Reporter: Tim Armstrong
• Created: 11/Jun/19 20:18
• Updated: 21/Jun/19 23:03
• Resolved: 21/Jun/19 23:03

Description

Repro:

$ impala-shell.sh -B --output_delimiter '||' -q 'select 1,1,1'
Starting Impala Shell without Kerberos authentication
Opened TCP connection to localhost:21000
Connected to localhost:21000
Server version: impalad version 3.3.0-SNAPSHOT DEBUG (build a0d96078a522ee72b1fbcedb5629451123afbfd0)
Query: select 1,1,1
Query submitted at: 2019-06-11 13:15:11 (Coordinator: http://tarmstrong-box:25000)
Query progress can be monitored at: http://tarmstrong-box:25000/query_plan?query_id=f14a14db36e6157c:aadd29bf00000000
Unknown Exception : Illegal delimiter ||, the delimiter must be a 1-character string.
Could not execute command: select 1,1,1

We have a test for this error message, but it only does a substring match.

I think the issue is that the validation of the argument is done only after the query is running, and ValueError is raised in DelimitedOutputFormatter and caught in a different place from most argument errors.