Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-8480

Replace ScopedFlagSetter with google::FlagSaver

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: Impala 3.0, Impala 3.1.0, Impala 3.2.0
    • Fix Version/s: None
    • Component/s: Infrastructure
    • Labels:
    • Epic Color:
      ghx-label-9

      Description

      Todd Lipcon pointed out that in code review google::FlagSaver already saves the state of all flags at time of construction and restores all of them on destruction. Currently, we rely on ScopedFlagSetter to save and restore modified flags in BE tests. We need to define a ScopedFlagSetter object per modified flags.

      It seems less clumsy for BE tests if all of them inherit from a base class which has google::FlagSaver as a class member. In this way, all modified flags in BE tests will be automatically restored and there is no need for a separate ScopedFlagSetter per modified flag.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              kwho Michael Ho
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: