[IMPALA-8317] impala-shell's config_file should be parsed correctly for 'keyval'

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 2.12.0, Impala 3.1.0
• Fix Version/s: Impala 3.3.0
• Component/s: Clients
• Epic Color: ghx-label-6
• Assignee: Fredy Wijaya
• Reporter: Vincent Tran
• Created: 18/Mar/19 17:33
• Updated: 26/Mar/19 17:58
• Resolved: 21/Mar/19 15:54

Description

[root@kiwi-2 ~]# cat ~/.impalarc
[impala]
keyval=foo=customers

[root@kiwi-2 ~]# impala-shell --ssl -q 'set'
Starting Impala Shell without Kerberos authentication
SSL is enabled. Impala server certificates will NOT be verified (set --ca_cert to change)
for keyval in keyvals:
Tokenized keyval: "f"
keyvals: "foo=customers"
Error: Could not parse key-value "f". It must follow the pattern "KEY=VALUE".
Usage: impala_shell.py [options]

It's apparent that the "KEY=VAL" string passed in is tokenized by characters here:
https://github.com/apache/impala/blob/969dea84f41cfccf863b14904958a5d2be91983f/shell/impala_shell.py#L1512

An immediate fix might be to cast options.keyval to an array ([options.keyval]):
https://github.com/apache/impala/blob/969dea84f41cfccf863b14904958a5d2be91983f/shell/impala_shell.py#L1719

Issue Links

• breaks: IMPALA-8337 Dataload fails due to ImportError: cannot import name OrderedDict from impala-shell
• causes: IMPALA-8330 Impala shell --config_file should use flag names and not dest variable names

Sub-Tasks

• Impala Doc: Document impala-shell config_file format: Closed