Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-8103

Plan hints show up as "--" comments in analysed query

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • Impala 3.2.0
    • Frontend
    • None

    Description

      I noticed that the hints added in IMPALA-5821 show up in the – style rather than /**/

          Sql Statement: select * from tpch.lineitem join /*+ broadcast */ tpch.part on l_partkey = p_partkey limit 
      ...
      Analyzed query: SELECT * FROM tpch.lineitem INNER JOIN
      -- +broadcast
      tpch.part ON l_partkey = p_partkey LIMIT CAST(5 AS TINYINT)
      

      I guess this works and maybe its fine, but I was really confused when I saw it. It looks like getPlanHintsSql() uses this to generate views in such a way that Hive will ignore the hints, but that concern doesn't seem relevant to this use case.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            asherman Andrew Sherman
            tarmstrong Tim Armstrong
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment