[IMPALA-7907] Multiple toSql() bugs in ScalarFunction

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 3.0
• Fix Version/s: Impala 3.2.0
• Component/s: Frontend
• Epic Color: ghx-label-5
• Assignee: Paul Rogers
• Reporter: Paul Rogers
• Created: 28/Nov/18 23:15
• Updated: 14/Mar/19 14:52
• Resolved: 01/Mar/19 17:50

Description

Each AST statement node has a toSql() implementation. The code for ScalarFunction and ToSqlUtils has a number of issues:

• If Location or Symbol are not set, they are shown as 'null'. Better to omit these clauses if the items are not available.
• The generated SQL does not follow the [Impala CREATE TABLE|] syntax. For example, the signature and return value are provided for JAVA functions, but should not be.
• Unlike other statements, this one is generated with a trailing newline.
• ToSql.getCreateFunctionSql() fails to separate functions with the semi-colon statement terminator.