[IMPALA-7902] Revise NumericLiteral to avoid analysis, fix multiple issues

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 3.0
• Fix Version/s: Impala 3.2.0
• Component/s: Frontend
• Epic Color: ghx-label-3
• Assignee: Paul Rogers
• Reporter: Paul Rogers
• Created: 27/Nov/18 23:48
• Updated: 14/Mar/19 14:41
• Resolved: 01/Mar/19 17:48

Description

The NumericLiteral class is a leaf node in the Impala FE AST. In order to address a number of pending issues, we must adjust this class to improve its semantics and fix a number of bugs.

See the linked JIRA tickets for the issues that this roll-up ticket addresses.

The issues are combined because they are tightly related; makes more sense to offer them as a single patch than as a series of disjoint patches.

Issue Links

• contains: IMPALA-7886 NumericLiteral constructor fails to round values to Decimal type
• contains: IMPALA-7887 NumericLiteral fails to detect numeric overflow
• contains: IMPALA-7888 Incorrect NumericLiteral overflow checks for FLOAT, DOUBLE
• contains: IMPALA-7891 Analyzer does not detect numeric overflow in CAST
• contains: IMPALA-7894 Parser does not catch double overflow
• contains: IMPALA-7896 Literals should not need explicit analyze step