[IMPALA-7887] NumericLiteral fails to detect numeric overflow

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 3.0
• Component/s: Frontend
• Epic Color: ghx-label-3
• Assignee: Paul Rogers
• Reporter: Paul Rogers
• Created: 26/Nov/18 17:03
• Updated: 02/Jan/19 11:23
• Resolved: 29/Dec/18 00:01

Description

The NumericLiteral constructor takes a value and a type. The code does not check that the value is within range of the type, allowing nonsensical values:

    NumericLiteral n = new NumericLiteral(new BigDecimal("123.45"),
        ScalarType.createDecimalType(3, 1));
    System.out.println(n.getValue().toString());
    n = new NumericLiteral(new BigDecimal(Integer.MAX_VALUE),
        Type.TINYINT);
    System.out.println(n.getValue().toString());

Prints:

123.45
2147483647

The value 123.45 is not valid for DECIMAL(3,1), nor is 2^31 valid for TINYINT.

According to the SQL-2016 standard, section 4.4:

If an assignment of some number would result in a loss of its most significant digit, an exception condition is raised.

The purpose of the constructor appears to be for "friendly" use where the caller promises not to create incorrect literals. Better would be to enforce this rule.

Issue Links

• Is contained by: IMPALA-7902 Revise NumericLiteral to avoid analysis, fix multiple issues