Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-7558

Optimize AddInterval timezone functions similarly to IMPALA-7521

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Backend
    • Labels:
    • Epic Color:
      ghx-label-9

      Description

      Currently AddInterval functions use boost's ptime and duration classes + there is a lot wrapper code to avoid exceptions caused by out of range timestamps and overflows caused by large intervals.

      A different way would be to split the intervals to day + time_of_day, and add these to TimestampValue::date_/time_ directly + handle day overflow. This would probably make these functions much faster and would not increase complexity, because most of this logic is already needed to avoid boost overflows.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              csringhofer Csaba Ringhofer
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: