[IMPALA-7388] JNI THROW_IF_ERROR macros use local scope variables which likely conflict

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Impala 3.1.0
• Epic Color: ghx-label-9
• Assignee: Todd Lipcon
• Reporter: Todd Lipcon
• Created: 02/Aug/18 08:16
• Updated: 14/Aug/18 04:39
• Resolved: 14/Aug/18 04:15

Description

The THROW_IF_ERROR macros all use a locally scoped variable "status". If they're called with a pattern like:

Status status = foo();
THROW_IF_ERROR(status, ...)

 

then the status variable inside the macro ends up being assigned to itself instead of the outer-scope variable. This makes it not throw or return, which is quite surprising.