Details
-
Improvement
-
Status: Reopened
-
Minor
-
Resolution: Unresolved
-
Impala 3.1.0
-
None
-
None
-
ghx-label-6
Description
Clang has a script clang-tidy-diff.py that can run clang tidy on a diff. This is substantially faster than the normal run-clang-tidy.py, because it compiles and analyzes only the changed files. This might also allow a more graceful way to incorporate new clang tidy checks. Kudu has implemented this functionality in their project. See [build-support/clang_tidy_gerrit.py|https://github.com/apache/kudu/blob/master/build-support/clang_tidy_gerrit.py.]
While this is faster, it is possible to have a code change that introduces a clang tidy issue in code that didn't change, so clang tidy on a diff might miss some issues.
We should evaluate whether this is something worth incorporating into Impala. It could be a good way for a developer to do a quick check before upload to Gerrit.