[IMPALA-7130] impala-shell -b / --kerberos_host_fqdn flag overrides value passed in via -i

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Impala 3.0, Impala 2.12.0
• Fix Version/s: Impala 2.13.0, Impala 3.1.0
• Component/s: Clients
• Epic Color: ghx-label-1
• Assignee: Vincent Tran
• Reporter: Vincent Tran
• Created: 06/Jun/18 17:17
• Updated: 19/Feb/19 18:29
• Resolved: 17/Jun/18 18:33

Description

When impala-shell -b / --kerberos_host_fqdn is used, the value will override one passed in via -i / --impalad.
This leads to the socket being created with the former value in the case when -b is used.

The problematic section of code is here

    if self.kerberos_host_fqdn is not None:
      host, port = (self.kerberos_host_fqdn.split(':')[0].encode('ascii', 'ignore'),
            int(self.impalad[1]))
    else:
      host, port = self.impalad[0].encode('ascii', 'ignore'), int(self.impalad[1])
    if self.use_ssl:
      if self.ca_cert is None:
        # No CA cert means don't try to verify the certificate
        sock = TSSLSocketWithWildcardSAN(host, port, validate=False)
      else:
        sock = TSSLSocketWithWildcardSAN(host, port, validate=True, ca_certs=self.ca_cert)
    else:
      sock = TSocket(host, port)
    if not (self.use_ldap or self.use_kerberos):
      return TBufferedTransport(sock)

The proposed fix is to always create the socket with the host passed in via -i

self.impalad[0].encode('ascii', 'ignore')

Issue Links

• is required by: IMPALA-2782 Allow Impala Shell to connect directly to impalad when config with proxy load balancer and kerberos
• relates to: IMPALA-7181 Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening