[IMPALA-6892] CheckHashAndDecrypt doesn't report disk and host where the verification failed

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 2.12.0
• Fix Version/s: Impala 2.13.0, Impala 3.1.0
• Component/s: Backend
• Labels: supportability
• Target Version: Impala 3.1.0
• Epic Color: ghx-label-5
• Assignee: Tim Armstrong
• Reporter: Mostafa Mokhtar
• Created: 19/Apr/18 21:49
• Updated: 27/Apr/18 20:47
• Resolved: 26/Apr/18 16:39

Description

Root causing block corruption is difficult because the Status message doesn't have the offending disk and host.

    Query Type: QUERY
    Query State: EXCEPTION
    Query Status: Block verification failure

Status TmpFileMgr::WriteHandle::CheckHashAndDecrypt(MemRange buffer) {
  DCHECK(FLAGS_disk_spill_encryption);
  SCOPED_TIMER(encryption_timer_);

  // GCM mode will verify the integrity by itself
  if (!key_.IsGcmMode()) {
    if (!hash_.Verify(buffer.data(), buffer.len())) {
      return Status("Block verification failure");
    }
  }
  return key_.Decrypt(buffer.data(), buffer.len(), buffer.data());
}